Skip to content

Add pnpm 9 support #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Add pnpm 9 support #379

merged 3 commits into from
Apr 17, 2024

Conversation

tobysmith568
Copy link
Member

@tobysmith568 tobysmith568 commented Apr 16, 2024

Includes required changes before we can merge #377 due to a breaking change in the pnpm licenses command.

  • Push the reading in of the package.json outside of resolveLicenseContent
  • Update the pnpm dependency resolution to support pnpm 9
  • Add pnpm e2e tests

@tobybessant - it might make sense to review the commits individually

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cd468eb) to head (ba8c990).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #379   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          491       505   +14     
  Branches        78        80    +2     
=========================================
+ Hits           491       505   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobysmith568 tobysmith568 merged commit 14d152c into main Apr 17, 2024
18 checks passed
@tobysmith568 tobysmith568 deleted the ts/pnpm-9-support branch April 17, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants