feat: Add canonical error codes for generic error handling. #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every error enum should have a conversion function to the canonical codes list. This can make client code more resilient to additions of error codes to per-function error enums, and simplify much of the error handling that currently needs to `switch()` over each error enum separately. It's still useful to have additional information from the per-function error enums to present the user with better error messages, but for programmatic error handling (e.g. bots), the canonical codes should always be sufficient context.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2711 +/- ##
=======================================
Coverage 73.05% 73.05%
=======================================
Files 149 149
Lines 30517 30545 +28
=======================================
+ Hits 22293 22314 +21
- Misses 8224 8231 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every error enum should have a conversion function to the canonical codes list. This can make client code more resilient to additions of error codes to per-function error enums, and simplify much of the error handling that currently needs to
switch()over each error enum separately.It's still useful to have additional information from the per-function error enums to present the user with better error messages, but for programmatic error handling (e.g. bots), the canonical codes should always be sufficient context.
This change is