Skip to content

update particle grass - #952

Merged
TokisanGames merged 1 commit into
TokisanGames:mainfrom
Xtarsia:minor-update-to-particle-grass
May 16, 2026
Merged

update particle grass#952
TokisanGames merged 1 commit into
TokisanGames:mainfrom
Xtarsia:minor-update-to-particle-grass

Conversation

@Xtarsia

@Xtarsia Xtarsia commented Mar 8, 2026

Copy link
Copy Markdown
Collaborator

Updates particle grass to match ground level region blending when background mode is flat or noise.

@TokisanGames

Copy link
Copy Markdown
Owner

Great that it respects the region blend. However it continues outside of the region boundary which is only good for Flat and odd for None/Noise.

@TokisanGames

Copy link
Copy Markdown
Owner

Adjusted the texture filter to be a uniform with a positive selection rather than negative filter.

Comment thread project/addons/terrain_3d/extras/particle_example/process_material.tres Outdated
@TokisanGames

TokisanGames commented Mar 8, 2026

Copy link
Copy Markdown
Owner

Are these unnecessary?

// Defined Constants
#define SKIP_PASS 0
#define VERTEX_PASS 1
#define FRAGMENT_PASS 2


The items in the gdscript info group and shadow mode should be moved up above the process & particle material. The last items should be:

  • process material
  • mesh
  • mesh material

I see info is read only, fine, it can go at the very top and marked read only like Terrain3D version so it greys out. Though setting distance by meters is much more intuitive than instance_spacing * cell_width*grid_width or whatever.
Maybe renaming min_draw_distance is in order. It looks more like max draw distance. But if it's read only, maybe calculated_distance or draw distance or calculated_radius.

@pl4ttenbau

Copy link
Copy Markdown

how does it look, any progress towards merge?

@TokisanGames

Copy link
Copy Markdown
Owner

All updates will be listed here.

@TokisanGames
TokisanGames force-pushed the minor-update-to-particle-grass branch from 890456a to f19e850 Compare May 16, 2026 02:01
@TokisanGames

Copy link
Copy Markdown
Owner

Are these unnecessary?
// Defined Constants
#define SKIP_PASS 0
#define VERTEX_PASS 1
#define FRAGMENT_PASS 2

These were removed from the main shader in #899, but were left in process_material and displacement_buffer.glsl, both removed now.

@TokisanGames
TokisanGames force-pushed the minor-update-to-particle-grass branch from f19e850 to 3c9bf2b Compare May 16, 2026 09:24
@TokisanGames

Copy link
Copy Markdown
Owner

Ok looks good, thanks @Xtarsia.

@TokisanGames
TokisanGames merged commit 204b676 into TokisanGames:main May 16, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants