Skip to content

Fix and upgrade plot_orbit #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 1, 2025
Merged

Fix and upgrade plot_orbit #155

merged 6 commits into from
May 1, 2025

Conversation

TomWagg
Copy link
Owner

@TomWagg TomWagg commented May 1, 2025

  • New feature: plot_orbit now shows the location of mergers (either stellar or GW), this can be turned off with the show_merger argument
  • Bug fix: plot_orbit hides the SN/merger locations if they occur after t_max (previously they were shown even though the orbit might not reach them)
  • Bug fix (#154): Ensure secondary SNe are still shown for bound binaries in plot_orbit

This will fix #154

@TomWagg TomWagg added bug Something isn't working enhancement New feature or request labels May 1, 2025
@TomWagg TomWagg self-assigned this May 1, 2025
Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b3a48d5) to head (f749539).
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #155      +/-   ##
===========================================
+ Coverage   99.13%   100.00%   +0.86%     
===========================================
  Files          15        15              
  Lines        1726      1715      -11     
===========================================
+ Hits         1711      1715       +4     
+ Misses         15         0      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomWagg TomWagg merged commit 6d6bc4d into main May 1, 2025
4 checks passed
@TomWagg TomWagg deleted the plot_orbit branch May 1, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot_orbit function only displays first supernova, no merger
1 participant