Skip to content

Conversation

@jbirky
Copy link

@jbirky jbirky commented Jun 24, 2025

added options to change the integrator, with defaults:

integrator=gi.DOPRI853Integrator 
integrator_kwargs={"a_tol": 1e-10, "r_tol": 1e-10}

@TomWagg TomWagg self-assigned this Jun 24, 2025
@TomWagg TomWagg added the enhancement New feature or request label Jun 24, 2025
@TomWagg
Copy link
Owner

TomWagg commented Jun 24, 2025

Love this @jbirky! Just a couple of small things and then I'll merge this:

  • Please update cogsworth/_version.py and docs/modules/changelog.rst to reflect the changes (I think this is worth a bump to v2.1.1)
  • It would be nice to save this saved to the Population on file as well. Could you update Population.save() and cogsworth.pop.load()?
    • You can copy what sfh_params does for saving the integrator params
    • For saving the Integrator, you can save the class name as a string and then use getattr(gi, NAME) to get it back for cogsworth.pop.load()

@TomWagg TomWagg changed the title add integrator options Add options to change galactic orbit integrator Jun 24, 2025
@TomWagg
Copy link
Owner

TomWagg commented Jun 24, 2025

@jbirky actually do v2.1.2 sorry, I just merged a PR (#157) which did v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants