[Fix/nodeLink] resetFilters() not working

[PandaIN95]

No description provided.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/Tomato6966/lavalink-client@176

commit: 181d587

[Tomato6966]

why call updatePlayer twice?
Idk what your fix really does?

[Tomato6966]

as far as i see you always remove all keys from the filters even when you wanna apply a filter. and then call a second time the updatePlayer with the filters object?
that makes no sense.
The code is / was correct.
If no filter is applied, the filter object is "empty"
if no eq is set, the equalizer is empty
if you call clearEQ you apply a new EQ with empty data to override the old one. (which is basically "the default equalizer")

if you call resetFilters
this is what's sent:

await this.player.node.updatePlayer({ 
  guildId: this.player.guildId,
  playerOptions: {
    filters: {},
    equalizer: whateverEqualizerDataIsRn..
  },
});

[PandaIN95]

When you send equalizer data (even if all band gains are zero) with empty filters {} the Filters won't reset. The only way to you can reset the filters is to send empty filters object (nodeLink bug/feature) The 1st updatePlayer is sending the empty filters object to removing player effects. Then 2nd updatePlayer is re applying the Equalizer (only if the band gains are not zero). Since resetFilters() is suppose to reset the filters not the Equalizer.

[Tomato6966]

According to nodelink it is a bug, which i have reported in the past which is now beeing resolved. no need to push a work around whichwill not be necessary since they will fix it. also we are not developing for nodelink, this is a lavalink client. if anything doesn't work as on lavalink, i will not change the code to make it fit. the user's should do it on the bot-client-side.

[PandaIN95]

fair enough did not knew they had fixed the issue