Skip to content

Conversation

@YogevBokobza
Copy link
Collaborator

@YogevBokobza YogevBokobza commented Jan 16, 2025

Description

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

Additional information

@pull-request-size pull-request-size bot added the size: s Pull request has 10 to 30 lines label Jan 16, 2025
@YogevBokobza YogevBokobza changed the title Time based power plug feat: time based power plug Jan 16, 2025
@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.91%. Comparing base (bff5352) to head (4361629).
⚠️ Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #833      +/-   ##
==========================================
- Coverage   98.99%   98.91%   -0.08%     
==========================================
  Files          11       11              
  Lines        1292     1294       +2     
==========================================
+ Hits         1279     1280       +1     
- Misses         13       14       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@YogevBokobza YogevBokobza marked this pull request as ready for review January 16, 2025 20:33
@auto-me-bot auto-me-bot bot added the status: needs review Pull request needs a review label Jan 16, 2025
@github-actions github-actions bot added Stale and removed Stale labels Feb 16, 2025
@github-actions github-actions bot added the Stale label Mar 21, 2025
@github-actions github-actions bot closed this Mar 28, 2025
@YogevBokobza YogevBokobza reopened this Mar 28, 2025
@YogevBokobza YogevBokobza force-pushed the time-based-power-plug branch from 5b044b7 to 863dde8 Compare March 28, 2025 17:53
@TomerFi TomerFi removed the Stale label Mar 28, 2025
@github-actions github-actions bot added the Stale label Apr 28, 2025
@github-actions github-actions bot closed this May 5, 2025
@TomerFi TomerFi reopened this May 5, 2025
@TomerFi TomerFi added type: wip Work in progress type: enhancement New feature or request and removed Stale type: wip Work in progress labels May 5, 2025
@YogevBokobza YogevBokobza force-pushed the time-based-power-plug branch from 863dde8 to 4361629 Compare May 19, 2025 19:56
@github-actions github-actions bot added the Stale label Jun 19, 2025
@github-actions github-actions bot closed this Jun 26, 2025
@TomerFi TomerFi added type: wip Work in progress and removed Stale labels Jun 26, 2025
@TomerFi TomerFi reopened this Jun 26, 2025
@github-actions github-actions bot added the Stale label Jul 27, 2025
@github-actions github-actions bot closed this Aug 3, 2025
@TomerFi
Copy link
Owner

TomerFi commented Aug 5, 2025

I'm removing the Stale action because it's not working as expected.

@TomerFi TomerFi reopened this Aug 5, 2025
@TomerFi
Copy link
Owner

TomerFi commented Oct 20, 2025

Any update about this one @YogevBokobza @thecode ?

@thecode
Copy link
Collaborator

thecode commented Oct 20, 2025

Any update about this one @YogevBokobza @thecode ?

My status is the same as reported at #335 (comment)

I don't know how to progress with this PR since the workaround trying to fix the problem with devices that report an 30:00:00 when the timer is disabled did not work on my device last time I checked.

I think @YogevBokobza need to get information from Switcher about this or alternatively a plug that use this value and fix the PR.

@TomerFi
Copy link
Owner

TomerFi commented Oct 20, 2025

@thecode I just want to make sure I understand, it's been a while since we discussed this. This PR works for @YogevBokobza 's device, but not for yours? Do we know if there's any difference between the devices? Maybe different firmwares?

@thecode
Copy link
Collaborator

thecode commented Nov 28, 2025

@thecode I just want to make sure I understand, it's been a while since we discussed this. This PR works for @YogevBokobza 's device, but not for yours? Do we know if there's any difference between the devices? Maybe different firmwares?

See #335 (comment) there is a difference in the firmware version, but since these devices can't be upgraded anymore and we don't know how to read the firmware version from them we must have a solution that will at least not raise an exception when an older device exists on the network.

@TomerFi
Copy link
Owner

TomerFi commented Nov 28, 2025

but since these devices can't be upgraded anymore and we don't know how to read the firmware version

@thecode So old devices can't upgrade their firmware? Wo we know what's behind this, is it like an old device not supported by the vendor anymore or something?

we must have a solution that will at least not raise an exception when an older device exists on the network.

@YogevBokobza Can we do that? Identify the device in question is an old device and log something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request has 10 to 30 lines Stale status: needs review Pull request needs a review type: enhancement New feature or request type: wip Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switcher power plug with firmware >= 1.46 supports timed base capabilities

3 participants