-
Notifications
You must be signed in to change notification settings - Fork 19
feat: time based power plug #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #833 +/- ##
==========================================
- Coverage 98.99% 98.91% -0.08%
==========================================
Files 11 11
Lines 1292 1294 +2
==========================================
+ Hits 1279 1280 +1
- Misses 13 14 +1 🚀 New features to boost your workflow:
|
5b044b7 to
863dde8
Compare
863dde8 to
4361629
Compare
|
I'm removing the Stale action because it's not working as expected. |
|
Any update about this one @YogevBokobza @thecode ? |
My status is the same as reported at #335 (comment) I don't know how to progress with this PR since the workaround trying to fix the problem with devices that report an 30:00:00 when the timer is disabled did not work on my device last time I checked. I think @YogevBokobza need to get information from Switcher about this or alternatively a plug that use this value and fix the PR. |
|
@thecode I just want to make sure I understand, it's been a while since we discussed this. This PR works for @YogevBokobza 's device, but not for yours? Do we know if there's any difference between the devices? Maybe different firmwares? |
See #335 (comment) there is a difference in the firmware version, but since these devices can't be upgraded anymore and we don't know how to read the firmware version from them we must have a solution that will at least not raise an exception when an older device exists on the network. |
@thecode So old devices can't upgrade their firmware? Wo we know what's behind this, is it like an old device not supported by the vendor anymore or something?
@YogevBokobza Can we do that? Identify the device in question is an old device and log something? |
Description
Checklist
Additional information