Skip to content

Conversation

@YogevBokobza
Copy link
Collaborator

@YogevBokobza YogevBokobza commented Mar 24, 2025

Description

Adding heater support.
heater is a new device, token based that acts more or less like Switcher Boiler devices.
This will solve the issue: #844

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

Additional information

@pull-request-size pull-request-size bot added the size: m Pull request has 30 to 100 lines label Mar 24, 2025
@YogevBokobza YogevBokobza changed the title Add heater support WIP - Add heater support Mar 24, 2025
@pull-request-size pull-request-size bot added size: l Pull request has 100 to 500 lines and removed size: m Pull request has 30 to 100 lines labels Mar 24, 2025
@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

❌ Patch coverage is 97.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.90%. Comparing base (bd5c398) to head (8669473).
⚠️ Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #835      +/-   ##
==========================================
- Coverage   98.99%   98.90%   -0.09%     
==========================================
  Files          11       11              
  Lines        1292     1370      +78     
==========================================
+ Hits         1279     1355      +76     
- Misses         13       15       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomerFi
Copy link
Owner

TomerFi commented Apr 10, 2025

@YogevBokobza I unsubscribed to avoid the notifications. Please ping when this is ready for review so I can resubscribe. Thank you.

@YogevBokobza YogevBokobza self-assigned this Apr 10, 2025
@github-actions github-actions bot added the Stale label May 11, 2025
@github-actions github-actions bot closed this May 18, 2025
@TomerFi TomerFi added type: wip Work in progress and removed Stale labels May 18, 2025
@YogevBokobza YogevBokobza reopened this May 19, 2025
@github-actions github-actions bot added the Stale label Jun 19, 2025
@github-actions github-actions bot closed this Jun 26, 2025
@TomerFi
Copy link
Owner

TomerFi commented Jun 26, 2025

Looks like something is wrong with the stale action, the type: wip label is exempt, this should not have been labeled stale:
https://github.com/TomerFi/aioswitcher/blob/dev/.github/workflows/stale.yml#L21

@TomerFi TomerFi removed the Stale label Jun 26, 2025
@TomerFi TomerFi reopened this Jun 26, 2025
@github-actions github-actions bot added the Stale label Jul 27, 2025
@github-actions github-actions bot closed this Aug 3, 2025
@TomerFi
Copy link
Owner

TomerFi commented Aug 5, 2025

I'm removing the Stale action because it's not working as expected.

@YogevBokobza
Copy link
Collaborator Author

YogevBokobza commented Nov 24, 2025

Update:
Almost ready to be Open.
Need to check the functionality of the power consumption and electric current

@YogevBokobza YogevBokobza marked this pull request as ready for review December 21, 2025 23:26
@auto-me-bot auto-me-bot bot added the status: needs review Pull request needs a review label Dec 21, 2025
@YogevBokobza YogevBokobza changed the title WIP - Add heater support Add heater support Dec 21, 2025
@YogevBokobza
Copy link
Collaborator Author

Finallly, heater is done for review.
@TomerFi @thecode

@YogevBokobza YogevBokobza changed the title Add heater support add heater support Dec 21, 2025
@YogevBokobza YogevBokobza changed the title add heater support feat: add heater support Dec 21, 2025
@YogevBokobza YogevBokobza removed the type: wip Work in progress label Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: l Pull request has 100 to 500 lines Stale status: needs review Pull request needs a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants