-
Notifications
You must be signed in to change notification settings - Fork 19
feat: add support for Switcher On Wall device #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #847 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 11 11
Lines 1292 1293 +1
=======================================
+ Hits 1279 1280 +1
Misses 13 13 🚀 New features to boost your workflow:
|
|
Hey |
- Add ON_WALL device type with hex code 0321 - Add 170-byte datagram length support in bridge - Add test coverage for new device type - Update supported devices documentation
a12c688 to
f70b103
Compare
|
@YogevBokobza Thanks for you response, I have updated the PR following your last comment. let me know if something still missing. As far as I understand in your PR you added a new Category but in my PR, I'm using WATER_HEATER category there fore it's not a lot as you mention. |
|
@giladtamam |
@YogevBokobza with help from cursor I got the following info:
|
|
Hi @giladtamam, I made some research on the OnWall - mind if I push a couple of my changes to this PR? For reference (ImHex pattern): |
Description
Checklist
Additional information