Skip to content

Conversation

@JeppeKlitgaard
Copy link
Contributor

@JeppeKlitgaard JeppeKlitgaard commented Jan 28, 2026

Ensures that fix to #2256 released in dxchange version 0.2.1 is used by setting lower version constraint.

Fixes #2256

@JeppeKlitgaard JeppeKlitgaard requested a review from a team as a code owner January 28, 2026 13:13
JeppeKlitgaard and others added 3 commits January 28, 2026 14:52
@github-project-automation github-project-automation bot moved this to Todo in UM 2026 Jan 29, 2026
@casperdcl casperdcl removed this from UM 2026 Jan 29, 2026
@JeppeKlitgaard
Copy link
Contributor Author

This is ready for review

@github-project-automation github-project-automation bot moved this to Todo in UM 2026 Jan 30, 2026
@casperdcl casperdcl removed this from UM 2026 Jan 30, 2026
@casperdcl casperdcl requested review from gfardell and paskino January 30, 2026 10:17
@casperdcl casperdcl requested a review from hrobarts January 30, 2026 10:17
@gfardell gfardell added the community-contribution Community-submitted pull requests from contributors outside the core team. label Jan 30, 2026
Copy link
Contributor

@hrobarts hrobarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeppeKlitgaard
Copy link
Contributor Author

Thanks for this @JeppeKlitgaard! I tested this with our Zeiss example and it works as expected so I'm happy to approve

I guess the version needs updating here as well TomographicImaging/scripts@main/env/cil_demos.yml TomographicImaging/scripts@main/env/cil_demos_cpu.yml TomographicImaging/scripts@main/env/cil_test.yml

Yes, that would be preferable. In principle it will resolve to the fixed version anyway unless something else constrains the version like a lock file or other dependency.

I think these should also be changed to using https://tomography.stfc.ac.uk/conda instead of the ccpi channel at some point, as part of #1870.

I am happy to submit a PR over there as well to pin these versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Community-submitted pull requests from contributors outside the core team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZEISSDataReader wrongly produces 64-bit data

4 participants