-
Notifications
You must be signed in to change notification settings - Fork 67
fix: constrain dxchange version to fix ZeissDataReader #2268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: constrain dxchange version to fix ZeissDataReader #2268
Conversation
Co-authored-by: Casper da Costa-Luis <[email protected]> Signed-off-by: Jeppe Klitgaard <[email protected]>
|
This is ready for review |
hrobarts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @JeppeKlitgaard!
I tested this with our Zeiss example and it works as expected so I'm happy to approve
I guess the version needs updating here as well
https://github.com/TomographicImaging/scripts/blob/main/env/cil_demos.yml
https://github.com/TomographicImaging/scripts/blob/main/env/cil_demos_cpu.yml
https://github.com/TomographicImaging/scripts/blob/main/env/cil_test.yml
Yes, that would be preferable. In principle it will resolve to the fixed version anyway unless something else constrains the version like a lock file or other dependency. I think these should also be changed to using https://tomography.stfc.ac.uk/conda instead of the ccpi channel at some point, as part of #1870. I am happy to submit a PR over there as well to pin these versions. |
Ensures that fix to #2256 released in
dxchangeversion 0.2.1 is used by setting lower version constraint.Fixes #2256