Skip to content

Conversation

@xiaochen-zhou
Copy link
Collaborator

Purpose of this pull request

Fix indefinite blocking by adjusting stopping condition in split reader
refer: apache/flink-connector-kafka#100

Does this PR introduce any user-facing change?

no

How was this patch tested?

Add tests KafkaTransactionalStoppingConditionTest#testStoppingConditionWithControlMessages()

Consider partition 0, where offsets 13 and 14 are valid records and 15 is a control record. If stoppingOffset is set to 15 for partition 0and properties.max.poll.records is configured to 1, checking only partitions that return records would miss offset 15. By consistently reviewing all assigned partitions, the consumer’s position jumps control record in the subsequent poll, allowing the system to escape.

Check list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant