Claude/skills#4
Merged
Merged
Conversation
- Disable redundant uv@jamie-bitflight-skills (python-engineering:uv covers it). - Remove 6 ghost rows from .claude/skills/README.md (onboard, ticket, pr-review, pr-summary, worktree-commit-merge, htmx-patterns); celery-patterns kept for H1. - Update SKILLS_HIRE.md to record F1/F2 completion. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Replace pyright/ty references with pyrefly across hooks, agents, skills, and commands to match actual dev dependency (pyrefly>=1.0.0) and CI usage (make check runs python -m pyrefly check). Six locations updated: .claude/settings.json hook, settings.md, code-reviewer agent, systematic-debugging skill, code-quality skill, and fix command. Mark P1 done in SKILLS_HIRE.md and record F3/F4/F5 type-checker portions resolved; remaining work in F3/F4/F5 is htmx-related, gated on P2. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Decide P2: never adopt htmx (no package installed, frontend uses plain JS fetch + JsonResponse). Apply consequences: - F4 systematic-debugging: drop Django Debug Toolbar and HTMX sections - F5 code-reviewer agent: drop HTMX checklist, partial-return branch, and htmx-alpine-patterns integration line - F6 django-forms/templates/pytest-django-patterns: insert "htmx not used in this project" note above htmx sections; preserve content for potential future adoption - F3 code-quality: remove stray HTMX HX-Request checklist row Add H1 celery-patterns skill grounded in actual project code (images/tasks.py, images/models.py, django_thumbnail/celery.py, django_thumbnail/settings/test.py): @shared_task convention, idempotency rule, exponential backoff retry, pass-IDs pattern, Image/ImageTask state flow with real field names, and CELERY_TASK_ALWAYS_EAGER testing mode. Mark wave 1 complete in SKILLS_HIRE.md. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…, policy Add three new local skills and a plugin enablement policy. Conclude all remaining SKILLS_HIRE.md tasks (H2, H3, P3, P4, C1). New skills (English, grounded in actual project code): - storage-s3 — boto3 singleton construction (internal_s3 / public_s3 in images/storage.py), MinIO endpoint split (in-cluster vs public-host), presign patterns, signature_version="s3v4", smoke-test verification via head_object, and patching-by-import-path guidance. - opentelemetry-patterns — span.set_attributes(dict) batch rule, web vs Celery worker telemetry separation (apps.CoreConfig.ready vs worker_process_init signal), SimpleSpanProcessor over BSP for fork safety (rationale from commit af308f6), per-process OTEL_SERVICE_NAME override in docker-compose, OTEL_SDK_DISABLED in settings/test.py. Policy: - .claude/SKILLS_POLICY.md catalogues the 36 python-engineering plugin skills: 12 approved (concept-only references), 24 disabled (CLI/TUI, packaging, orchestrator family, ty/prek-assumptions, stack-incompatible). Maps each project need to its local tool. Defines the quality-check chain (P4): /fix inner-loop, /code-quality + code-reviewer pre-PR, make check + make test in CI. P3 decision: django-extensions stays uninstalled. No usage signals (zero references in pyproject.toml, settings, Makefile, agents, commands, or user memory). The skill remains as a future-activation reference with a DORMANT banner and explicit activation steps. Also fix the leftover example "core.EmailAccount / metabox.Thread" to use the project's actual models. Post-audit fixes (factual accuracy): - storage-s3: rename cited Image methods to real names (upload_original, delete_from_storage) per images/models.py:86,89 - opentelemetry-patterns: document per-process OTEL_SERVICE_NAME override (web=django-thumbnail-app, worker=django-thumbnail-worker) required by Jaeger trace separation in test_smoke.py - SKILLS_POLICY: correct plugin skill count from 38 to 36 Convert F6 htmx notes and django-extensions dormant banner from Traditional Chinese to English to match the rest of the skill corpus. SKILLS_HIRE.md fully closed; all three waves are now ✅ DONE. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
All planned tasks (P1-P4, F1-F6, H1-H3, C1) are complete. Remove the internal planning docs and strip the dead "Companion docs" footer from SKILLS_POLICY.md. Operational policy lives in: - .claude/SKILLS_POLICY.md (plugin enablement + quality-check chain) - .claude/skills/*/SKILL.md (concrete skills) - .claude/skills/django-extensions/SKILL.md (DORMANT banner) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.