Add output format options to the mpg123 decoder#86
Open
mdluo wants to merge 5 commits intoTooTallNate:masterfrom
Open
Add output format options to the mpg123 decoder#86mdluo wants to merge 5 commits intoTooTallNate:masterfrom
mdluo wants to merge 5 commits intoTooTallNate:masterfrom
Conversation
This was referenced Apr 25, 2018
LinusU
reviewed
Apr 26, 2018
| var channels = opts.channels || (MPG123_MONO | MPG123_STEREO); | ||
| var signed = opts.signed ? MPG123_ENC_SIGNED : 0; | ||
| var float = opts.float ? MPG123_ENC_FLOAT : 0 | ||
| var bitDepth = MPG123_ENC_8 | MPG123_ENC_16 | MPG123_ENC_24 | MPG123_ENC_32; |
Collaborator
There was a problem hiding this comment.
Is this line correct? 🤔 why are we oring them together?
LinusU
approved these changes
Apr 26, 2018
Collaborator
LinusU
left a comment
LinusU
left a comment
There was a problem hiding this comment.
Just one thing I'm wondering about...
Collaborator
|
Looks great! |
|
Doesn't that make Decoder a Transcoder? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue: #52
Previous PR: #83
First call
mpg123_format_noneto clear the output format table, then callmpg123_formatto set the output format based on the option parameter of the Decoder constructor.Encoding table: https://github.com/TooTallNate/node-lame/blob/master/deps/mpg123/src/libmpg123/mpg123.h.in#L348-L388
mpg123_format_none: https://www.mpg123.de/api/group__mpg123__output.shtml#ga931ca238347de394901c3baa13e7a8f8mpg123_format: https://www.mpg123.de/api/group__mpg123__output.shtml#gadad5794afc300a997e517dbe397dc2c7Inspired by: https://sourceforge.net/p/mpg123/mailman/message/25123550/