Replaced deprecated Nan and node functions to fix compilation in node 12 - fixed#99
Open
tomscytale wants to merge 3 commits intoTooTallNate:masterfrom
Open
Replaced deprecated Nan and node functions to fix compilation in node 12 - fixed#99tomscytale wants to merge 3 commits intoTooTallNate:masterfrom
tomscytale wants to merge 3 commits intoTooTallNate:masterfrom
Conversation
|
Is that possible to proceed with any of the PRs please? @TooTallNate |
|
I've published this with prebuilt binaries (similar to #85) to my github packages: https://github.com/schneefux/node-lame |
Author
|
@TooTallNate - it would be great if you could merge and release this - as it stands node-lame is unable to work with the last 2 lts versions of node. |
|
yeah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clone of #97 but updates .travis.yml to remove older versions of node which break with this change