Skip to content

Improve border rendering (#152) and add full icon theme search support (#155)#171

Open
y2w8 wants to merge 5 commits intoToqozz:masterfrom
y2w8:master
Open

Improve border rendering (#152) and add full icon theme search support (#155)#171
y2w8 wants to merge 5 commits intoToqozz:masterfrom
y2w8:master

Conversation

@y2w8
Copy link

@y2w8 y2w8 commented Nov 8, 2025

Summary

This PR combines improvements to the rendering system and the icon theme handling.

Rendering Improvements

  • Fixed rounded borders so both outer and inner corners render correctly.
  • Improved handling of border width and radius.
  • Ensured cleaner border and background separation with proper fill rules.
    Screencast_20251108_160137.webm

Icon Theme Enhancements

  • Added proper icon theme lookup system supporting:
    • /usr/share/icons
    • /usr/local/share/icons
    • ~/.local/share/icons
    • ~/.icons
    • /usr/share/pixmaps
    • /var/lib/flatpak/exports/share/icons
    • $XDG_DATA_DIRS/icons
  • Supports multiple formats: .svg, .svgz, .png, .xpm
  • Handles scalable and symbolic icons correctly.
  • Added fallback to hicolor (optional) and predefined default theme (Adwaita).
    Screencast_20251108_230054.webm

Additional Notes

  • All directory checks are validated before access for better performance.
  • Keeps backward compatibility with existing configuration.
  • Makes icon lookup consistent across different Linux environments.

Related issue

Fixes #152
FIxes #155

@y2w8 y2w8 changed the title Fix borders rounded Improve border rendering (#152) and add full icon theme search support (#155) Nov 8, 2025
@Toqozz
Copy link
Owner

Toqozz commented Nov 11, 2025

Hey! Thanks for the pull request, this has been on the list for a while.

  1. Was any of this PR written with AI? Just asking because it changes how I would review it.
  2. The outer border is intentionally square to match the window. Compositors like compton draw shadows based solely on the window rect rather than the content of the window, so it looks buggy in that scenario. Having said that, I can see the value in both -- would you mind making it a configuration option?

@y2w8
Copy link
Author

y2w8 commented Nov 11, 2025

1.Yeh some of it because my English not that good and afraid it’s not be like professional if I type it / if you mean the code no it just give the idea of fill rule and fallback icons

  1. For what? Option for making border fully rounded? Or the icons fallback

@Toqozz
Copy link
Owner

Toqozz commented Nov 11, 2025

No worries :)

For what? Option for making border fully rounded? Or the icons fallback

For making the border fully rounded.

@y2w8
Copy link
Author

y2w8 commented Nov 11, 2025

Done.

@Toqozz
Copy link
Owner

Toqozz commented Nov 13, 2025

Thank you, I'll give this a try over the weekend.

Sorry for the delay!

@Toqozz
Copy link
Owner

Toqozz commented Nov 16, 2025

I'm so sorry, my Linux machine is having problems so I might take a little longer to get to this.

@y2w8
Copy link
Author

y2w8 commented Nov 16, 2025

No problem

@Toqozz
Copy link
Owner

Toqozz commented Jan 21, 2026

Really sorry I haven't gotten to this yet, have just been very busy.

Promise I will get to it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon paths Rounded Borders

2 participants