fix(eio/upgrade): 25s upgrade latency due to multiple polling req while upgrading #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totodore
added
C-Bug
Totodore
force-pushed
the
fix-multiple-polling-req
branch
2 times, most recently
from
a6af282 to
4f73318
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported in #479, the socket.io client might send multiple HTTP polling requests while upgrading. Socketioxide is sending exactly one
NOOPpacket to the first polling request and then do not expect more polling requests. When this is happening (probably because of some state desynchronisation on the client side). The client is waiting for the end of the second polling request which is caused by the ping request packet only after the ping interval (25s by default).Solution
Socketioxide is now sending aNOOPpacket to any number of incoming polling request if the socket is currently being upgraded.Socketioxide is now pausing the heartbeat mechanism when upgrading to avoid resending a ping packet on the polling connection before the upgrade is fully complete.