Fix selecting items with selectOnBlur=false #412
Merged
+55
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `closeMenu()` in the blur handler causes the menu to disappear before a user can select an item.
|
@rangermeier is attempting to deploy a commit to the tcaweb Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
TotomInc
approved these changes
Dec 23, 2025
Owner
|
Thanks for your contribution @rangermeier, this is a nice PR 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405
Calling
closeMenu()in the blur handler for the search input causes the menu to disappear before a user can select an item. Just removing this call fixes this issue. The menu will still close when the user moves the focus away from the component.This also fixes another issue: when the menu is open, clicking the indicator did close and immediately re-open the menu.