-
Notifications
You must be signed in to change notification settings - Fork 97
[NU-2065] Wrong event time of events coming from time windows #7801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
updated: #8056 |
...ala/pl/touk/nussknacker/engine/flink/util/transformer/aggregate/ExtendedWindowOperator.scala
Outdated
Show resolved
Hide resolved
...ala/pl/touk/nussknacker/engine/flink/util/transformer/aggregate/ExtendedWindowOperator.scala
Show resolved
Hide resolved
...est/scala/pl/touk/nussknacker/engine/flink/util/transformer/aggregate/TransformersTest.scala
Outdated
Show resolved
Hide resolved
...ala/pl/touk/nussknacker/engine/flink/util/transformer/aggregate/ExtendedWindowOperator.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for a while before merging - I'm not sure whether the change will work with event matching multiple windows at once (e.g. sliding windows) due to calling trigger for multiple windows in Flink WindowOperator.processElement
implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
epic. Good job
Describe your changes
Checklist before merge