Skip to content

[NU-2065] Wrong event time of events coming from time windows #7801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: staging
Choose a base branch
from

Conversation

paw787878
Copy link
Contributor

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

Copy link
Contributor

github-actions bot commented Mar 28, 2025

updated: #8056
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@paw787878 paw787878 marked this pull request as ready for review March 31, 2025 12:58
Copy link
Contributor

@raphaelsolarski raphaelsolarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for a while before merging - I'm not sure whether the change will work with event matching multiple windows at once (e.g. sliding windows) due to calling trigger for multiple windows in Flink WindowOperator.processElement implementation.

Copy link
Contributor

@raphaelsolarski raphaelsolarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

epic. Good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants