Skip to content

[NU-2140] Enricher mocking #7982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
May 28, 2025
Merged

[NU-2140] Enricher mocking #7982

merged 25 commits into from
May 28, 2025

Conversation

raphaelsolarski
Copy link
Contributor

@raphaelsolarski raphaelsolarski commented Apr 23, 2025 •
edited
Loading

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe ui labels Apr 30, 2025
@github-actions github-actions bot mentioned this pull request Apr 30, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 30, 2025 •
edited
Loading

created: #8086
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

This was referenced Apr 30, 2025
Closed
Closed
@github-actions github-actions bot added the docs label May 5, 2025
This was referenced May 5, 2025
Closed
Merged
Merged
@raphaelsolarski raphaelsolarski marked this pull request as ready for review May 7, 2025 08:59
@raphaelsolarski raphaelsolarski changed the title Enricher mocking [NU-2140] Enricher mocking May 7, 2025
@raphaelsolarski
Copy link
Contributor Author

Screenshot 2025-05-07 at 11 13 28
Screenshot 2025-05-07 at 11 13 52
Screenshot 2025-05-07 at 11 14 35

@github-actions github-actions bot mentioned this pull request May 8, 2025
Closed
arkadius
arkadius reviewed May 8, 2025
View reviewed changes
This was referenced May 13, 2025
Closed
Closed
@raphaelsolarski
mockExpression added variables from context to suggestions
007026a
@raphaelsolarski
mockExpression interpreter tests added
9e0d0e2
@raphaelsolarski
Changelog entry added
94ce709
@raphaelsolarski
Docs entry
86ca79b
@raphaelsolarski
Intermediate trait added for future changes around mocked output
fa3d412
@raphaelsolarski
File rename
0083f50
@raphaelsolarski
Label rendering fixup
6efd378
@raphaelsolarski
FE label Mocked Output Expression renamed to Mock
63df2b1
@raphaelsolarski
Hint text added
32f93d3
@raphaelsolarski
Docs fixup
80acc25
@raphaelsolarski
Additional scenario compiler test
439e903
@raphaelsolarski
fe feature flag added
5f98b94
@raphaelsolarski
rebase fixup
e0fc6bb
@raphaelsolarski
review fixes - wip
ab64381
@raphaelsolarski
review fixes:
e2b0fef 
* jsontemplate added as default editor to mock expression
* handling null in jsontemplate
* additional type matching verification to help provide valid jsontemplate expression under mock value (todo: probably to be moved to jsontemplate parser)
@raphaelsolarski
review fixes: EnricherMockedOutput sealed trait removed
708ae6a
@raphaelsolarski
docks removed (hidden feature)
9859227
@raphaelsolarski
Expected type validation added to JsonTemplateParser
fc78334
@raphaelsolarski raphaelsolarski merged commit 0dab5dd into staging May 28, 2025
19 checks passed
@raphaelsolarski raphaelsolarski deleted the enricher-mocking branch May 28, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
client client main fe docs ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphaelsolarski @arkadius