Skip to content

[NU-2149] End scenario without sink #8004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 7, 2025
Merged

[NU-2149] End scenario without sink #8004

merged 18 commits into from
May 7, 2025

Conversation

mgoworko
Copy link
Contributor

@mgoworko mgoworko commented Apr 28, 2025 •
edited
Loading

Describe your changes

Scenarios no longer have to end with final sink node. Other node may be the final node of the scenario. The change is optional, by default no changes in Nu behavior.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@mgoworko mgoworko marked this pull request as ready for review April 29, 2025 10:28
@github-actions github-actions bot added the docs label Apr 29, 2025
@mgoworko mgoworko requested a review from arkadius April 30, 2025 12:24
@github-actions github-actions bot mentioned this pull request May 5, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025 •
edited
Loading

created: #8049
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@mgoworko mgoworko requested review from arkadius and removed request for arkadius May 6, 2025 10:20
@github-actions github-actions bot mentioned this pull request May 6, 2025
Closed
arkadius
arkadius approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, one minor comment added

@github-actions github-actions bot mentioned this pull request May 7, 2025
Closed
@mgoworko mgoworko merged commit 150d58c into staging May 7, 2025
30 of 31 checks passed
@mgoworko mgoworko deleted the end-scenario-without-sink branch May 7, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgoworko @arkadius