Skip to content

fixing duplicates in user defined lists in fragment input #8024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2025
Merged

fixing duplicates in user defined lists in fragment input #8024

merged 3 commits into from
May 8, 2025

Conversation

vder
Copy link
Contributor

@vder vder commented May 2, 2025

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe ui labels May 2, 2025
@github-actions github-actions bot mentioned this pull request May 2, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025 •
edited
Loading

created: #8050
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@vder vder force-pushed the additional_fix_for_duplicates_in_user_defined_lists_in_fragment_input branch from 45341e3 to 08a29fd Compare May 6, 2025 11:54
@github-actions github-actions bot mentioned this pull request May 7, 2025
Closed
@vder vder force-pushed the additional_fix_for_duplicates_in_user_defined_lists_in_fragment_input branch 2 times, most recently from 7d03187 to 804cd1b Compare May 7, 2025 09:42
@github-actions github-actions bot mentioned this pull request May 8, 2025
Closed
@vder vder force-pushed the additional_fix_for_duplicates_in_user_defined_lists_in_fragment_input branch from 191200a to 922169f Compare May 8, 2025 07:56
@vder vder merged commit 85c2287 into staging May 8, 2025
14 checks passed
@vder vder deleted the additional_fix_for_duplicates_in_user_defined_lists_in_fragment_input branch May 8, 2025 08:58
vder added a commit that referenced this pull request May 8, 2025
@vder
fixing duplicates in user defined lists in fragment input (#8024)
0a12d2f 
* fixing duplicates in user defined lists in fragment input

* move trim to onValueChange

* adjustment after CR

---------

Co-authored-by: Piotr Fałdrowicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dzuming Dzuming Dzuming approved these changes

Assignees
No one assigned
Labels
client client main fe ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vder @Dzuming