Skip to content

ContextId refactor #8119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 12, 2025
Merged

ContextId refactor #8119

merged 15 commits into from
Jun 12, 2025

Conversation

mgoworko
Copy link
Contributor

@mgoworko mgoworko commented May 20, 2025

Describe your changes

Changes:

  • separated parts of the ContextId structure - it is no longer a simple string, but instead case class that contains a few fields representing scenario id, source node id, index etc.
  • it does not fundamentally change the ContextId representation - after serialization to string is looks the same
  • with one significant modification - the Split node now adds suffix to context ids of each of its outgoing branches; Split essentially clones the event and sends copy to each of its branches, those outgoing contexts need to be identifiable
  • the new ContextId structure is returned in test results data structures

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@mgoworko mgoworko changed the title In progress, do not review: ContextId refactor ContextId refactor May 21, 2025
@mgoworko mgoworko requested a review from arkadius May 22, 2025 09:05
@mgoworko mgoworko force-pushed the context-id-refactor branch from b23d52c to eebc459 Compare June 6, 2025 12:24
@github-actions github-actions bot added client client main fe ui labels Jun 6, 2025
@mgoworko mgoworko requested a review from arkadius June 11, 2025 16:03
@mgoworko mgoworko requested a review from arkadius June 12, 2025 10:56
@mgoworko mgoworko merged commit e66fa49 into staging Jun 12, 2025
19 checks passed
@mgoworko mgoworko deleted the context-id-refactor branch June 12, 2025 11:47
mateuszkp96 pushed a commit that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants