Add "local" connector type #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sputnikci
reviewed
Oct 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
============================================
- Coverage 72.52% 72.11% -0.41%
- Complexity 592 601 +9
============================================
Files 142 145 +3
Lines 1889 1944 +55
Branches 121 127 +6
============================================
+ Hits 1370 1402 +32
- Misses 462 485 +23
Partials 57 57
Continue to review full report at Codecov.
|
SpOOnman
suggested changes
Oct 23, 2019
Contributor
SpOOnman
left a comment
SpOOnman
left a comment
There was a problem hiding this comment.
Thank you for your PR! I have a few suggestions on this, please read them and tell me what you think.
src/main/java/pl/touk/sputnik/connector/ConnectorFacadeFactory.java
Outdated
Show resolved
Hide resolved
src/test/java/pl/touk/sputnik/connector/local/LocalFacadeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/pl/touk/sputnik/connector/local/LocalFacadeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/pl/touk/sputnik/connector/local/LocalFacadeTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Contributor
Author
|
I'm actually just realized that this patch doesn't actually work right. I'm using jgit wrong. It does the check on the uncommitted changes (since it does a git diff) whereas I need to do the equivalent of a git show. Will push a fix. |
Runs analysis tools on the HEAD of the local git repository and reports to the log. Allows someone to check for any comments before pushing to Gerrit/Gitlab.
Contributor
|
Thank you for your submission! I'm sorry I was unavailable for so long. Great job! 👍 |
rufuslevi
pushed a commit
to rufuslevi/sputnik
that referenced
this pull request
Mar 12, 2024
Add local connector type. Runs analysis tools on the HEAD of the local git repository and reports to the log. Fixes TouK#195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #195
Runs analysis tools on the HEAD of the local git repository and reports
to the log.
Allows someone to check for any comments before pushing to
Gerrit/Gitlab.