[UUID DB part 3] Clean up town/nation/resident renaming logic #7963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LlmDl
requested changes
Sep 25, 2025
Member
LlmDl
left a comment
LlmDl
left a comment
There was a problem hiding this comment.
I made a few comments pointing out deprecations that didn't have a "since version X" in their comments, but there are more. Please add a "@deprecated since 0.101.2.*" to each of the newly deprecated methods.
Towny/src/main/java/com/palmergames/bukkit/towny/db/TownyDataSource.java
Show resolved
Hide resolved
Towny/src/main/java/com/palmergames/bukkit/towny/object/Nation.java
Outdated
Show resolved
Hide resolved
Warriorrrr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enforces that towns/nations/residents have non null UUIDs and prevents them from being changed later, in order to have reliable hashCode and equals methods.
That in turn allows us to remove all of the complicated renaming while still having everything just work.
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.