Skip to content

Generate PreconditionFailure #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
palfrey merged 1 commit into from
May 14, 2026
Merged

Generate PreconditionFailure #2333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ test_suite(
"//nativelink-config:doc_test",
"//nativelink-error:doc_test",
"//nativelink-macro:doc_test",
"//nativelink-proto:doc_test",
"//nativelink-scheduler:doc_test",
"//nativelink-service:doc_test",
"//nativelink-store:doc_test",
Expand Down
8 changes: 1 addition & 7 deletions nativelink-proto/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ load(
"@rules_rust//rust:defs.bzl",
"rust_binary",
"rust_doc",
"rust_doc_test",
"rust_library",
)

Expand Down Expand Up @@ -98,6 +97,7 @@ genrule(
"google/protobuf/empty.proto",
"google/protobuf/timestamp.proto",
"google/protobuf/wrappers.proto",
"google/rpc/error_details.proto",
"google/rpc/status.proto",
"src/main/java/com/google/devtools/build/lib/buildeventstream/proto/build_event_stream.proto",
"src/main/java/com/google/devtools/build/lib/packages/metrics/package_load_metrics.proto",
Expand Down Expand Up @@ -186,9 +186,3 @@ rust_doc(
crate = ":nativelink-proto",
visibility = ["//visibility:public"],
)

rust_doc_test(
name = "doc_test",
timeout = "short",
crate = ":nativelink-proto",
)
Copy link
Copy Markdown
Member Author

@palfrey palfrey May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some annoying reason, the new proto makes some things that look like doc tests, but fail. Given all the code is generic generated code, it shouldn't really have any doc tests anyways.

1 change: 1 addition & 0 deletions nativelink-proto/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ name = "nativelink-proto"
version = "1.1.0"

[lib]
doctest = false # because some of the generated protos have things that look like doctests but break
name = "nativelink_proto"
path = "genproto/lib.rs"

Expand Down
370 changes: 370 additions & 0 deletions nativelink-proto/genproto/google.rpc.pb.rs
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading