nix: migrate off deprecated crane stdenv arg to stdenvSelector#2379
nix: migrate off deprecated crane stdenv arg to stdenvSelector#2379amaanq wants to merge 3 commits into
stdenv arg to stdenvSelector#2379Conversation
|
@amaanq is attempting to deploy a commit to the native-link-web-assets Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Very interesting pull request @amaanq! Thank you for the fix. |
|
Seems like the failing mac job may just be flaky |
|
@amaanq This is a weird failure. |
Yeah it seems like a transient network failure from a glance, maybe re-running that job might fix it? |
| }: let | ||
| craneLibFor = p: (crane.mkLib p).overrideToolchain pkgs.lre.stableRustFor; | ||
| nightlyCraneLibFor = p: (crane.mkLib p).overrideToolchain pkgs.lre.nightlyRustFor; | ||
| # On Linux we build fully static musl binaries, elsewhere the default stdenv. |
There was a problem hiding this comment.
I like this but I'd like to explore giving people the option to run glibc at times when they need it. Musl is good default, though, for obvious reasons.
There was a problem hiding this comment.
Sure, that sounds reasonable. I could do that in a follow-up pr
|
I am going to cut a release with this fix soon. |
|
@amaanq LGTM |
awesome! |
Description
Crane deprecated passing
stdenvintomkCargoDerivation, however, since the input of crane here is a bit behind, no warning is emitted yet. I use Nativelink between my own machines, but I set the crane input here to follow a more up-to-date crane, and as such, I get hit with the following warning:This PR's change is defensive in nature, but I went ahead and updated the crane input as well. If that's undesireable, please let me know and I can revert that, the fix works without bumping crane.
Thanks for the really cool project :)
Fixes # (issue)
(No issue, just something I ran into)
Type of change
A defensive future-bug fix.
How Has This Been Tested?
I ran this locally, overriding my input with the local path.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is