Fix bug in buf_channel::consume() where exact size doesn't receive eof #858
Conversation
In the event the receiver is receiving the exact size of data, but the writer sends all the data, but not an eof then the writer decides not to send the eof the receiver will consider it "good". This issue has been fixed by this PR.
There was a problem hiding this comment.
cc: @adam-singer
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04 (waiting on @blakehatch)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Cargo Dev / macos-13, Remote / large-ubuntu-22.04, windows-2022 / stable (waiting on @blakehatch)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained
TraceMachina#858) In the event the receiver is receiving the exact size of data, but the writer sends all the data, but not an eof then the writer decides not to send the eof the receiver will consider it "good". This issue has been fixed by this PR.
In the event the receiver is receiving the exact size of data, but the writer sends all the data, but not an eof then the writer decides not to send the eof the receiver will consider it "good". This issue has been fixed by this PR.
This change is