Use wrapper file for Windows VST3 module compilation

Instead of adding compile flags to the SDK's module_win32.cpp directly,
use a wrapper source file that sets up the necessary preprocessor
definitions (NOMINMAX, WIN32_LEAN_AND_MEAN, _UNICODE, etc.) before
including the SDK source. This ensures proper compilation environment
when building outside the VST3 SDK's CMake context.

https://claude.ai/code/session_01AY9chvBEmsCVjNZSUkNcbw

Author: claude

CMakeLists.txt

@@ -138,16 +138,9 @@ if(PLUGINVAL_VST3_VALIDATOR)
         set_source_files_properties(${VST3_MODULE_MAC_FILE} PROPERTIES
             COMPILE_FLAGS "-fobjc-arc")
     elseif(WIN32)
-        set(VST3_MODULE_WIN_FILE ${vst3sdk_SOURCE_DIR}/public.sdk/source/vst/hosting/module_win32.cpp)
-        list(APPEND VST3ValidatorFiles ${VST3_MODULE_WIN_FILE})
-        # Add Windows-specific compile flags for compatibility
-        if(MSVC)
-            set_source_files_properties(${VST3_MODULE_WIN_FILE} PROPERTIES
-                COMPILE_FLAGS "/DNOMINMAX /DWIN32_LEAN_AND_MEAN /D_SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING")
-        else()
-            set_source_files_properties(${VST3_MODULE_WIN_FILE} PROPERTIES
-                COMPILE_DEFINITIONS "NOMINMAX;WIN32_LEAN_AND_MEAN;_SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING")
-        endif()
+        # Use wrapper file that sets up preprocessor definitions before including SDK source
+        list(APPEND VST3ValidatorFiles
+            Source/vst3validator/module_win32_wrapper.cpp)
     endif()
 
     target_sources(pluginval PRIVATE ${VST3ValidatorFiles})

Source/vst3validator/module_win32_wrapper.cpp

@@ -0,0 +1,51 @@
+/*==============================================================================
+
+  Copyright 2018 by Tracktion Corporation.
+  For more information visit www.tracktion.com
+
+   You may also use this code under the terms of the GPL v3 (see
+   www.gnu.org/licenses).
+
+   pluginval IS PROVIDED "AS IS" WITHOUT ANY WARRANTY, AND ALL WARRANTIES, WHETHER
+   EXPRESSED OR IMPLIED, INCLUDING MERCHANTABILITY AND FITNESS FOR PURPOSE, ARE
+   DISCLAIMED.
+
+ ==============================================================================*/
+
+/**
+ * Wrapper file for VST3 SDK module_win32.cpp
+ * This wrapper ensures proper preprocessor setup before including the SDK source.
+ */
+
+#if defined(_WIN32)
+
+// Prevent Windows headers from defining min/max macros
+#ifndef NOMINMAX
+#define NOMINMAX
+#endif
+
+// Reduce Windows header bloat
+#ifndef WIN32_LEAN_AND_MEAN
+#define WIN32_LEAN_AND_MEAN
+#endif
+
+// Silence deprecation warning for experimental/filesystem
+#ifndef _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING
+#define _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING
+#endif
+
+// Ensure _UNICODE is defined for proper Windows API usage
+#ifndef _UNICODE
+#define _UNICODE
+#endif
+
+#ifndef UNICODE
+#define UNICODE
+#endif
+
+// Include the actual VST3 SDK module implementation
+// Note: The path is relative to this file's location, but the build system
+// sets up include directories so we can use the SDK path directly
+#include "public.sdk/source/vst/hosting/module_win32.cpp"
+
+#endif // _WIN32