Fix playing notes notes retriggering when changing clip during first loop in Clip Launcher #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dikadk
force-pushed
the
linkedClipLauncher
branch
from
f3272b2 to
4f2e025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step to reproduce:
Issue only exists in the first loop if clip is played by ClipLauncher, so I had to modify StepSequencerDemo to include ClipLauncher to debug.
bug.mp4
fixed_full.mp4
This is updated StepSequencerDemo which uses ClipLuancher
StepSequencerDemo.h.zip