Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP Cli path #67

Merged
merged 8 commits into from
Mar 23, 2025
Merged

WP Cli path #67

merged 8 commits into from
Mar 23, 2025

Conversation

TrafeX
Copy link
Owner

@TrafeX TrafeX commented Mar 23, 2025

This eliminate the need to use the path running commands in wp cli

@TrafeX TrafeX mentioned this pull request Mar 23, 2025
@TrafeX
Copy link
Owner Author

TrafeX commented Mar 23, 2025

I made a few changes to avoid the addition to the entrypoint.sh. I moved the ENV variable you had earlier into the Dockerfile. This seems to work 👍

It's best practice to do as much as possible in the Dockerfile which happens on build time instead of in the entrypoint.sh which is executed on runtime. If sometime goes wrong in in the entrypoint.sh, it will crash the container when it starts.

@TrafeX TrafeX merged commit 3d0c667 into master Mar 23, 2025
1 check passed
jure-ve added a commit to jure-ve/docker-wordpress that referenced this pull request Mar 29, 2025
Define WordPress path so that the WP CLI works from every location (TrafeX#67) from TrafeX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants