-
Notifications
You must be signed in to change notification settings - Fork 22
Add reflection bindings #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the contribution, I haven't looked too deeply yet at the setup / implementation, however, I think the wrapper structs at least should be snake_case rather then how they are defined now. |
|
Im also ok with bumping this to the 2021 edition but we should do that in a separate PR from this one. |
|
I'm not strongly opinionated about it, but I kept the original member names verbatim so that they are easier to locate in documentation. |
…ome tweaks to the reflection example.
…d from the original
|
I'm also interested in having this.
|
I think that's pretty much it yeah, do if you'd like to pick it up I'm happy to merge the contribution. Also update the contributor readme with all involved in this PR, of course! |
I think this covers most of the currently available reflection API exposed by ID3D12ShaderReflection.
I've added code comments about this in the change but want to call it out explicitly:
#[rustfmt::skip]in places where I felt it was clearer without rustfmtI've used code from the following MIT-licensed sources: