Skip to content

Conversation

@zopsicle
Copy link

Fixes #85.

@zopsicle
Copy link
Author

zopsicle commented Jun 11, 2025

Tbh to be completely safe these functions should also check that the blob's data is suitably aligned for T and also impose a T: bytemuck::AnyBitPattern + bytemuck::NoUninit bound. It's probably better to just make them always return [u8].

@MarijnS95 MarijnS95 changed the title Check for null pointer from IDxcBlob::get_buffer_pointer (#85) Check for null pointer in DxcBlob::as(_mut)_slice() Jun 11, 2025
@Jasper-Bekkers
Copy link
Member

@zopsicle PRs must be signed with GPG signature before we can merge, could you do that please? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DxcBlob::as_slice violates slice::from_raw_parts precondition when IDxcBlob::get_buffer_pointer returns null

2 participants