fix: 432 async draco loader #433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JaimeTorrealba
approved these changes
Jul 3, 2024
fehnomenal
approved these changes
Jul 8, 2024
alvarosabu
added
feature
alvarosabu
approved these changes
Jul 23, 2024
|
I changed the base branch to v4 to include it on the next version, @emavitta could you please check the conflict on the useGLTF so we can merge? Thanks |
|
oh my... i never noticed this pr was still pending. I just noticed the pr wasn't there after updating my project..... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #432, wrapping
new DRACOLoader()in an async function to prevent racing condition, e.g. while looping through an array of models with draco compression.