feat: update dependencies and fix StatsGl component #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded `stats-gl` from version 2.0.1 to 3.6.0 - Added a temporary TypeScript comment in `StatsGl.ts` to handle an expected error while waiting for an update from `stats-gl`.
commit: |
andretchen0
suggested changes
Jan 7, 2025
| @@ -93,6 +93,7 @@ export const StatsGl = defineComponent<StatsGlProps>({ | |||
| expose({ instance: statsGl }) | |||
|
|
|||
| const node = document.body | |||
| // @ts-expect-error waiting for stats-gl update https://github.com/RenaudRohlinger/stats-gl/issues/16 | |||
| const statContainer = statsGl.dom || statsGl.container | |||
There was a problem hiding this comment.
tldr: This is a problem on the Cientos side. Not with stats-gl. Running pnpm build appears to clear the type error.
I can confirm that I also saw the type error if I removed the @ts-expect-error here.
This was odd, because checking the installed exported types from stats-gl 3.6, there's an public dom field.
Digging into it, after doing this initially ...
- Check out this PR
pnpm i- In VS Code, right-click on
statsGlon the line shown above, then select "Go to Type Definition"
... the editor showed a 2.4 version of the Stats type. That version doesn't have a public dom field.
After running pnpm build, the 2.4 version was fully removed for me. Then the following line works in the editor without a @ts-expect-error
const statContainer = statsGl.dom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stats-glfrom version 2.0.1 to 3.6.0StatsGl.tsto handle an expected error while waiting for an update fromstats-gl.