Fix issues in the duplicate item clarification workflow#281
Open
sanpohi wants to merge 3 commits intoTrevoke:masterfrom
Open
Fix issues in the duplicate item clarification workflow#281sanpohi wants to merge 3 commits intoTrevoke:masterfrom
sanpohi wants to merge 3 commits intoTrevoke:masterfrom
Conversation
Owner
|
Ah this is great, thank you. Is it too much to ask you to also add tests? If you don't know how to do that, that's fine, just let me know. |
Author
|
Thanks for the feedback. I also think adding tests would be helpful. While working on this PR, I noticed the current tests missed checking the I was able to set up the Docker images for running tests locally. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues when clarifying duplicate items from the queue:
org-gtd-clarify-setup-windowsdue todelete-other-windowsorg-gtd-id-get-create, which can cause confusionOrg-GTD Clarifyis inconsistent with other temporary buffers that useOrg GTD ...Note that the logic of
org-gtd-clarify-itemcan be reused if we persist the item toinbox.orgimmediately after popping it from the queue. This allows the generation of an Org GTD ID, consistent with the standard clarification process where the Org GTD ID remains in the inbox unless organized. This also prevents the data loss when canceling the clarification.