Update FindNetCDF.cmake with better tests#262
Open
gsjaardema wants to merge 1 commit intoTriBITSPub:masterfrom
Open
Update FindNetCDF.cmake with better tests#262gsjaardema wants to merge 1 commit intoTriBITSPub:masterfrom
gsjaardema wants to merge 1 commit intoTriBITSPub:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of NetCDF-4.5.0, the
NC_MAX_VARSandNC_MAX_DIMSlimits are no longer enforced, so it isn't necessary to check their values. While updating the test and whether to perform it or not, I discovered that the current parsing ofNC_MAX_VARSandNC_MAX_DIMSwas returning incorrect values.To fix this, I added a REGEX to strip the C comment from the end of the string.
I also parsed more values from the
netcdf_meta.hfile if it exists instead of parsing some values from it and some from thenc-configscript.Tested on several versions of NetCDF and values all look reasonable