Fix default completed_dir #8531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egbertbouman
force-pushed
the
fix_completed_dir
branch
from
29b4b3e to
4b9e54a
Compare
egbertbouman
force-pushed
the
fix_completed_dir
branch
from
4b9e54a to
38bd6a6
Compare
|
validate |
qstokkink
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly fixes #8523.
When downloading normally,
completed_diris set to""by the UI. However, when creating a new torrent and setting it to seed automatically,completed_diris set toNone(this comes fromdownload_defaults). This is then cast to str to become"None". This PR fixes this issue by not settingNoneinfrom_defaults.Note that
completed_dir = Nonein the config file is interpreted as a directory called None. The same goes forsaveas = None.