Skip to content

Fix/cleanup tribler.spec #8542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

Fix/cleanup tribler.spec #8542

merged 1 commit into from
Apr 14, 2025

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Apr 14, 2025 •
edited
Loading

Fixes a MacOS build issue found during sanity testing:

File "tribler.spec", line 5, in <module>
    import imp
ModuleNotFoundError: No module named 'imp'

This PR:

  • Fixes tribler.spec using import imp, which doesn't exist in Python 3.12.
  • Removes old tribler.spec workarounds for a missing Linux font, pydantic support, and Python 2->3 compatibility.

@qstokkink qstokkink marked this pull request as ready for review April 14, 2025 08:10
@qstokkink qstokkink changed the title WIP: Fix/cleanup tribler.spec READY: Fix/cleanup tribler.spec Apr 14, 2025
@qstokkink qstokkink changed the title READY: Fix/cleanup tribler.spec Fix/cleanup tribler.spec Apr 14, 2025
@qstokkink qstokkink merged commit b971156 into Tribler:main Apr 14, 2025
7 checks passed
@qstokkink qstokkink deleted the fix_mac_setup branch April 14, 2025 08:28
@qstokkink
Copy link
Contributor Author

Alright, works 🎉

Ubuntu 22, Windows x64 also works 🎉
Windows x32 unconfirmed 😕
Ubuntu aarch64 is failing ❌ (still running Python 3.10, oops)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qstokkink @egbertbouman