Skip to content

Updated popular torrents SQL #8546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Updated popular torrents SQL #8546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/tribler/core/database/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

from lz4.frame import LZ4FrameDecompressor
from pony import orm
from pony.orm import Database, db_session, desc, left_join, raw_sql, select
from pony.orm import Database, db_session, desc, left_join, raw_sql, select # noqa: F401 (desc is used by pony!)
from pony.orm.dbproviders.sqlite import keep_exception

from tribler.core.database.orm_bindings import misc, torrent_metadata, tracker_state
Expand Down Expand Up @@ -569,16 +569,20 @@ def get_entries_query( # noqa: C901, PLR0913
msg = "With `popular=True`, only `metadata_type=REGULAR_TORRENT` is allowed"
raise TypeError(msg)

t = time() - POPULAR_TORRENTS_FRESHNESS_PERIOD
return select(
g for g in self.TorrentMetadata
for health in self.TorrentState
if health.has_data == 1 # The condition had to be written this way for the partial index to work
and health.last_check >= t and (health.seeders > 0 or health.leechers > 0)
and g.health == health
).order_by(
lambda g: (desc(g.health.seeders), desc(g.health.leechers), desc(g.health.last_check))
).limit(POPULAR_TORRENTS_COUNT)
t = time() - POPULAR_TORRENTS_FRESHNESS_PERIOD # noqa: F841 (this is used in the following query)
return self.TorrentMetadata.select_by_sql("""
SELECT ChannelNode.* FROM
(SELECT * FROM TorrentState
WHERE TorrentState.has_data == 1
AND TorrentState.last_check >= $t
AND (TorrentState.seeders > 0 OR TorrentState.leechers > 0)
ORDER BY TorrentState.seeders DESC, TorrentState.leechers DESC, TorrentState.last_check DESC
LIMIT $POPULAR_TORRENTS_COUNT) results
LEFT JOIN
ChannelNode WHERE ChannelNode.health == results.rowid
GROUP BY ChannelNode.infohash
;
""")
else:
pony_query = left_join(g for g in self.TorrentMetadata)

Expand Down