Skip to content

Replace tdef innards with ATP #8550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Apr 22, 2025

Fixes #8544

This PR:

  • Updates marshmallow to be pinned at 3.26.1, because 4.0.0 is incompatible with IPv8. This also requires aiohttp==3.11.16. I opened an issue for this on IPv8.
  • Updates the TorrentDef to lean more on the atp.

@qstokkink qstokkink force-pushed the upd_tdef_ltatp branch 4 times, most recently from 08b449d to 6bce2bd Compare April 22, 2025 14:59
@qstokkink qstokkink changed the title WIP: Replace tdef innards with ATP READY: Replace tdef innards with ATP Apr 23, 2025
@qstokkink qstokkink marked this pull request as ready for review April 23, 2025 09:31
Copy link
Member

@egbertbouman egbertbouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The TorrentDef stuff really needed a cleanup.

@qstokkink qstokkink changed the title READY: Replace tdef innards with ATP Replace tdef innards with ATP Apr 23, 2025
@qstokkink qstokkink merged commit 8dcd5e2 into Tribler:main Apr 23, 2025
7 checks passed
@qstokkink qstokkink deleted the upd_tdef_ltatp branch April 23, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Replace TorrentDef internals with libtorrent.add_torrent_params
2 participants