Skip to content

feat: test cancel after partial withdrawal - #192

Merged
Glittersup merged 3 commits into
TricklePay:mainfrom
connelevalsam:feat/issue-35
Aug 30, 2026
Merged

feat: test cancel after partial withdrawal#192
Glittersup merged 3 commits into
TricklePay:mainfrom
connelevalsam:feat/issue-35

Conversation

@connelevalsam

Copy link
Copy Markdown
Contributor

closes #65

Acceptance criteria satisfied:

  • Counter overflow handled without reusing an id — contract.rs:129 uses checked_add(...).ok_or(StreamCountExhausted).
  • Failure mode documented — error.rs:48, contract.rs create-stream doc step 5, and README.
  • Boundary test covers the counter — create_stream_rejects_an_exhausted_counter (at u64::MAX) and create_stream_accepts_the_final_id_then_refuses_the_next (at u64::MAX-1).

@drips-wave

drips-wave Bot commented Aug 28, 2026

Copy link
Copy Markdown

@connelevalsam Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Same fixes as PR TricklePay#194: remove duplicate tests left by a bad merge and
rework the event-ordering helpers for the soroban-sdk 25 events API where
env.events().all() exposes only the latest invocation's events.
@Glittersup
Glittersup merged commit 8489747 into TricklePay:main Aug 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test cancel after partial withdrawal

2 participants