chore: add clippy.toml with project lint configuration - #203
Merged
Conversation
- Add clippy.toml that raises too-many-arguments-threshold to 8 so the create_stream entry point (8 params, all part of the on-chain ABI) is accommodated at the project level. - Remove the inline #[allow(clippy::too_many_arguments)] from contract.rs that is now superseded by the configuration file. Resolves TricklePay#157
|
@DevSolex Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #157
Adds a
clippy.tomlat the repository root that records the project's deliberate Clippy configuration in one place, replacing the inline#[allow]attribute that was the only suppression in the codebase.Changes
clippy.toml(new): raisestoo-many-arguments-thresholdfrom the default 7 to 8. Thecreate_streamfunction takes 8 parameters — all distinct fields in the public on-chain ABI — so the threshold is raised at the project level rather than suppressed at the call site.contracts/stream/src/contract.rs: removes the#[allow(clippy::too_many_arguments)]attribute fromcreate_streamsinceclippy.tomlnow covers it. A comment is left explaining the threshold decision.Verification