fix(build): preserve native SQLite artifacts for Docker architectures - #10825
Open
iansherr wants to merge 4 commits into
Open
fix(build): preserve native SQLite artifacts for Docker architectures#10825iansherr wants to merge 4 commits into
iansherr wants to merge 4 commits into
Conversation
Contributor
Greptile SummaryThe PR makes server artifacts portable across supported Docker architectures and libc variants.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; both previously reported issues are fixed in the current code.
|
| Filename | Overview |
|---|---|
| apps/server/package.json | The packaging workflow now verifies native SQLite artifacts before creating the server archive, resolving the prior verifier-bypass finding. |
| apps/server/scripts/verify-build-artifacts.mjs | The verifier checks all four Docker targets and now converts its module URL to a filesystem path correctly. |
| apps/server/scripts/build.ts | Server builds request retention of all supported Linux architecture and libc variants. |
| scripts/build-utils.ts | SQLite trimming supports preserving both Linux architectures while retaining existing host-target behavior by default. |
| apps/server/spec/build-checks/artifacts.spec.ts | Build checks explicitly assert that the required Docker-native SQLite binaries are present. |
| apps/server/vitest.build.config.mts | Build-artifact tests no longer load the unrelated general server setup. |
Reviews (4): Last reviewed commit: "fix(build): handle encoded verifier path..." | Re-trigger Greptile
iansherr
marked this pull request as ready for review
August 6, 2026 22:58
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
iansherr
marked this pull request as draft
August 6, 2026 23:15
iansherr
marked this pull request as ready for review
August 6, 2026 23:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR exists
Plugin testing in isolated Docker environments revealed that a server artifact built on one host could omit the native
better-sqlite3binaries required by another supported Docker architecture.The existing build behavior was appropriate when artifacts were primarily used on the platform where they were produced. Cross-platform Docker testing introduced the requirement that the same server artifact remain deployable across supported Linux architectures and libc variants.
What changed
Validation
pnpm --filter=server test-build— 4 build checks passedpnpm --filter=server verify-build-artifacts— 4 native artifacts verifiedpnpm --filter=server docker-build-debianpnpm --filter=server docker-build-alpineScope
This PR is limited to server artifact composition and verification. Plugin-manager behavior and developer-harness changes are submitted separately.