dev: make plugin development and test harnesses reproducible - #10826
Open
iansherr wants to merge 2 commits into
Open
dev: make plugin development and test harnesses reproducible#10826iansherr wants to merge 2 commits into
iansherr wants to merge 2 commits into
Conversation
Contributor
Greptile SummaryThis PR improves reproducibility for plugin development and test harnesses.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/script-deployer/src/dev.ts | Adds environment-driven harness configuration, complete core initialization, explicit scripting settings, and asynchronous watcher invocation. |
| apps/client/src/widgets/attribute_widgets/attribute_detail.spec.ts | Gives cold module-import positioning tests explicit per-test timeouts. |
| apps/client/src/widgets/type_widgets/spreadsheet/locales.spec.ts | Gives the intentionally expensive locale import test an explicit timeout. |
| apps/server/src/services/image_provider.spec.ts | Gives the JPEG quality-clamping test additional time under worker contention. |
| packages/splitjs/tsconfig.json | Adds a no-emit JavaScript-aware TypeScript project configuration for Split.js. |
Sequence Diagram
sequenceDiagram
participant E as Environment
participant D as Script Deployer
participant C as Trilium Core
participant DB as SQLite
participant S as HTTP Server
E->>D: Data directory, port, script directory
D->>C: initializeCoreForDev()
C->>DB: Open configured database
D->>DB: Create initial database if missing
D->>S: Start Trilium server
D->>DB: Create token and scripts folder
D->>D: Deploy scripts and watch changes
Reviews (2): Last reviewed commit: "Merge branch 'main' into agent/plugin-de..." | Re-trigger Greptile
iansherr
marked this pull request as ready for review
August 6, 2026 23:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR exists
Plugin development required isolated Trilium instances with configurable data directories, ports, and script sources. The existing script-deployer workflow used fixed local paths and did not initialize the complete server core before deployment testing.
Those defaults were reasonable for the original single-instance development workflow. Plugin development exposed the need for a more configurable and faithful local test harness without changing production defaults.
What changed
@stylistic/eslint-plugindev dependency required by the repository's existing ESLint configurations, allowing clean installs to run lint.Validation
pnpm typecheckgit diff --checkManual verification
TRILIUM_DEV_DATA_DIR,TRILIUM_DEV_PORT, andTRILIUM_SCRIPT_SOURCE_DIR.Scope
This PR is limited to development and test-harness reliability. Production plugin behavior and Docker artifact composition are submitted separately.