Skip to content

Print collection - add missing link/titles for reference-link links #9489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eliandoran merged 4 commits into from
Apr 19, 2026
Merged

Print collection - add missing link/titles for reference-link links #9489

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62a8fb2
fix(print): add missing note title for links (content renderer aware …
contributor Apr 18, 2026
4579e4d
Revert "fix(print): add missing note title for links (content rendere…
contributor Apr 18, 2026
9d8d7bd
fix(print): missing note title for reference links
contributor Apr 18, 2026
e9b1b2d
chore(print): parallelize loading note reference links
contributor Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/client/src/services/content_renderer_text.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ export async function postProcessRichContent(note: FNote | FAttachment, $rendere
const noteIdsToPrefetch = referenceLinks.map((i, el) => getNoteIdFromLink(el));
await froca.getNotes(noteIdsToPrefetch);

for (const el of referenceLinks) {
await Promise.all(referenceLinks.toArray().map(async (el) => {
const innerSpan = document.createElement("span");
await link.loadReferenceLinkTitle($(innerSpan), el.href);
await link.loadReferenceLinkTitle($(innerSpan), el.getAttribute("href"));
el.replaceChildren(innerSpan);
}
}));

await rewriteMermaidDiagramsInContainer($renderedContent[0] as HTMLDivElement);
await formatCodeBlocks($renderedContent);
Expand Down
Loading