better ide navigation and encapsulation for max migration version#9919
Merged
eliandoran merged 2 commits intoMay 27, 2026
Merged
Conversation
dosubot
Bot
added
the
size:S
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the migration versioning system by replacing the MAX_MIGRATION_VERSION constant with a getMaxMigrationVersion() function and exporting the MIGRATIONS array directly. A review comment suggests improving the robustness of the new getMaxMigrationVersion() function by using optional chaining and a default value to prevent potential runtime errors if the migrations array is empty.
contributor
force-pushed
the
qol-max-migration-version-definition
branch
from
b0753f6 to
63aa2c6
Compare
eliandoran
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main motivation is better IDE navigation towards max migration value. Now, when you navigate to max version from AppInfo it goes as close as possible to actual version number. Previously, you had to do additional clicking and scrolling to view the value.
As a bonus, getMaxMigrationVersion is better API that hides implementation details of migration definitions.