Conversation
danmcd
requested changes
Jan 27, 2025
Contributor
danmcd
left a comment
danmcd
left a comment
There was a problem hiding this comment.
Please put testing notes in the Jira ticket.
danmcd
approved these changes
Mar 7, 2025
Contributor
danmcd
left a comment
danmcd
left a comment
There was a problem hiding this comment.
Before you push, would you like me to test this version of eng using SmartOS or any other Triton components I tend to build locally? Our ipxe comes to mind, and I can build it in the 19.4 zone I have marked for ipxe builds, albeit using some overrides due to PI mismatch.
Contributor
Author
|
Sure, thanks. I do the same PI overrides... |
Contributor
|
Re-ping-ing here. I don't need to update the SmartOS builds immediately, but AFAIC this can get pushed unless there's a gating factor I'm missing. |
tsoome
approved these changes
Mar 28, 2025
Contributor
|
@jperkin With recent discoveries while creating a 24.4.1 regular build zone for smartos-ui, we probably need this up NOW rather than later. |
Contributor
Author
|
Sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supercedes #68. It's mostly the same, but updates images to 24.4.1 instead, and bumps dates to 2025. I also incorporated @bahamat feedback from last time about retaining
git@github.comauth.I've been testing with this during initial work on the jenkins-agent and sdcnode updates.