Conversation
FreeBSD needs arc_adjust_zthr to run periodically for kstats to be updated. A comment in the code suggests this may have been the original intent in illumos as well: https://github.com/openzfs/zfs/blob/c946d5a91329b075fb9bda1ac703a2e85139cf1c/module/zfs/arc.c#L4697-L4700 Create the thread with a 1 second timer. Reviewed-by: Matt Macy <mmacy@FreeBSD.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #10371 Change-Id: I3977d33889f87d515e2a434ff208c2916ff68468
Change-Id: Ie3d6598023dd6831960e0959fe48f5688468d3f5
danmcd
left a comment
danmcd
left a comment
There was a problem hiding this comment.
Seems a good first attempt. The idea is, "you can now write into zfs_arc_max and zfs_arc_min and have the system fix things," right?
| */ | ||
| uint64_t zfs_arc_max; | ||
| uint64_t zfs_arc_min; | ||
| uint64_t zfs_arc_max = 0; |
There was a problem hiding this comment.
C defaults to 0 for globals, but I do like the consistency.
yes, and the few others too (they all do exist). The important thing is, we do get all the dependent other values re-evaluated according to new settings. |
There are 2 points to take:
|
2 participants
Extracted 2 commits and tailored to our current code.