Skip to content

thoth debug supports passing binary into MDB#142

Open
geek wants to merge 2 commits intoTritonDataCenter:masterfrom
geek:node-debug
Open

thoth debug supports passing binary into MDB#142
geek wants to merge 2 commits intoTritonDataCenter:masterfrom
geek:node-debug

Conversation

@geek
Copy link
Copy Markdown

@geek geek commented Sep 21, 2016

No description provided.

@jclulow
Copy link
Copy Markdown
Contributor

jclulow commented Sep 21, 2016

Would it be better to provide a way to upload a binary for a particular thoth dump, and to have thoth debug then use it each time automatically?

@geek
Copy link
Copy Markdown
Author

geek commented Sep 21, 2016

@jclulow we could do that. I do think your suggestion will be easier to use, but I prefer to make it a separate step and the path explicit. Would you thoth upload node and then associate it with an object?

@jclulow
Copy link
Copy Markdown
Contributor

jclulow commented Sep 21, 2016

Presumably this is for situations where the debugging information is not included in the core file itself, so the original executable is also needed to provide mdb with a complete picture?

I think I would probably extend thoth upload to optionally accept a binary as well as a core file, and to track it as a first class artefact alongside the core itself.

@geek
Copy link
Copy Markdown
Author

geek commented Sep 21, 2016

@jclulow that makes sense. I will let you make the call on if we should do that. It may complicate the code a bit to detect which of the files is the core, as well as checking if the binary is already uploaded (for potential reuse).

@geek
Copy link
Copy Markdown
Author

geek commented Sep 29, 2016

@jclulow this is now updated to upload the program that created the core and associate it with the core for loading into MDB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants