TRITON-2529 Add support in CLB for configuring global timeouts via metadata #8
Conversation
Allow users to customize HAProxy timeout values through the new
cloud.tritoncompute:timeouts metadata key. The format uses a JSON-like
syntax: {queue:0,connect:5000,client:60000,server:180000}
All timeout parameters are optional - unspecified values use defaults:
- queue: 0 (unlimited)
- connect: 2000ms
- client: 55000ms
- server: 120000ms
Changes:
- Add TIMEOUTS_KEY metadata constant
- Add TimeoutConfig struct and default constants
- Add parse_timeouts() function for parsing metadata
- Convert 001-defaults.cfg to Askama template for dynamic rendering
- Update configure_haproxy() to use dynamic defaults
- Add comprehensive unit tests for timeout parsing
- Add documentation in README.md
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Confirming: I see a Claude credit in this branch's first commit, so RFD 187 attribution applies, and you're taking responsibility for this, correct? I've pinged @TritonDataCenter/triton-engineering for this. Also, I will be opening a TRITON- ticket. The lack of description here needs to be fixed, but the summary on this PR is perfect for said ticket. Anything in this PR's conversation that's ticket-pertinent will be pasted there. This will include test-notes and other things that would go in a ticket. |
danmcd
changed the title
danmcd
changed the title
Added copyright notice for Edgecast Cloud LLC.
nshalman
left a comment
nshalman
left a comment
There was a problem hiding this comment.
I am comfortable with this. Thank you!
|
@blovett-ec I will need the following put here for transfer into the ticket:
|
danmcd
left a comment
danmcd
left a comment
There was a problem hiding this comment.
I've added what I think is a decent statement-of-problem-and-solution in the ticket. I will need your testing notes, esp. in light of comments below.
| input.trim().eq_ignore_ascii_case("true") | ||
| } | ||
|
|
||
| /// Parse timeout overrides from metadata |
There was a problem hiding this comment.
Don't we have a Rust crate that'll do this for us? New parsing code feels like a place for security problems, even in a safer language like Rust.
There was a problem hiding this comment.
@nshalman may be able to answer this better, esp. with our new Rust monorepo.
There was a problem hiding this comment.
Possibly a case of, "yes, but it'd be like bringing an atom-bomb to a knife fight," scenario. Will let @nshalman confirm/deny and mark-as-resolved as appropriate.
danmcd
left a comment
danmcd
left a comment
There was a problem hiding this comment.
Forgot to check request-changes.
danmcd
left a comment
danmcd
left a comment
There was a problem hiding this comment.
Removing my request-changes. Still have a question about json parsing, but less blocking.
- Change TimeoutConfig fields from u32 to std::time::Duration - Support timeout value formats: plain number (ms), 'ms' suffix, 's' suffix - Clamp client/server timeouts to maximum of 60 minutes - Fail on invalid timeout values instead of falling back to defaults - Add getter methods (queue_ms, etc.) for HAProxy template rendering 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
danmcd
left a comment
danmcd
left a comment
There was a problem hiding this comment.
My +1 stands even after cargo fmt.
| input.trim().eq_ignore_ascii_case("true") | ||
| } | ||
|
|
||
| /// Parse timeout overrides from metadata |
There was a problem hiding this comment.
Possibly a case of, "yes, but it'd be like bringing an atom-bomb to a knife fight," scenario. Will let @nshalman confirm/deny and mark-as-resolved as appropriate.
3 participants
Uh oh!
There was an error while loading. Please reload this page.